Add base styles visual tests for button #8948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor!: Button base styles * remove `--vaadin-icon-size` prop definition * rename some props - bg → background. - use "container" consistently.
* refactor!: text-field base styles * add "helper-above-field" variant to dev page * add an example with long texts to the dev page * add `--vaadin-input-field-require-indicator-color` prop * remove commented code * Update common.js * fix: adjust readonly focus styles
web-padawan
force-pushed
the
base-styles
branch
2 times, most recently
from
ee5b8fe to
ce4b0e6
Compare
jouni
approved these changes
Apr 23, 2025
|
web-padawan
added a commit
that referenced
this pull request
Apr 23, 2025
web-padawan
added a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created setup for base styles visual tests and added those for
buttonpackage.To run, use
yarn test:base. To update screenshots per component, runyarn update:base --group buttonetc.Note: some states are apparently missing (especially
hoverandactive) but I added test cases regardless.Type of change